Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix JSDoc type generation #1780

Merged
merged 1 commit into from
Sep 14, 2023
Merged

Fix JSDoc type generation #1780

merged 1 commit into from
Sep 14, 2023

Conversation

jribbink
Copy link
Contributor

Closes #1779

Surprisingly simple fix. Apparently rollup-plugin-typescript2 doesn't ingest .js files by default.

@jribbink jribbink requested a review from a team as a code owner September 14, 2023 02:22
@changeset-bot
Copy link

changeset-bot bot commented Sep 14, 2023

⚠️ No Changeset found

Latest commit: 963025b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@nialexsan nialexsan merged commit 75b1c36 into release-typescript Sep 14, 2023
1 check passed
@nialexsan nialexsan deleted the jribbink/jsdoc-fix branch September 14, 2023 15:12
@jribbink jribbink linked an issue Sep 14, 2023 that may be closed by this pull request
nialexsan pushed a commit that referenced this pull request Nov 1, 2023
nialexsan added a commit that referenced this pull request Nov 7, 2023
* Nialexsan/add types (#1710)

* switch to uuid from @onflow/utils-uid

* create tsconfigs

* typedefs in ts

* types for actor util

* types for address util

* Revert "switch to uuid from @onflow/utils-uid"

This reverts commit 2a15ef5.

* PKG -- [util-actor] converted to ts

* updated tsconfig

* fixed ts types generation

* Resolve circular dependency

* ts rlp

* change type location

* more types

* build types during regular build

* fix tests

* VSN -- [root] Changeset

* Merge remote-tracking branch 'origin/master' into nialexsan/add-types

* Revert "Resolve circular dependency"

This reverts commit 36efc7d.

* update lock

* VSN -- [root] changeset

* Implement typescript for several branches & adjust configuration (#1750)

Implements typescript support for: @onflow/rlp, @onflow/util-uid, @onflow/util-template, @onflow/util-logger, @onflow/util-invariant, @onflow/util-encode-key, @onflow/util-address

* Convert @onflow/types to TS (#1760)

* [WIP] Convert @onflow/types to TS

* stash

* kind of working

* fix package.json

* fix dictionary

* fix tests

* stash

* strong type tests

* remove any

* rename

* changeset

* PKG -- [util-actor] Enhance TS support (#1761)

* PKG -- [util-actor] Enhance TS support

* rename handlerfnmap

* PKG -- [types] Simplify generics for @onflow/types (#1772)

* PKG -- [types] Simplify generics

* Fix array

* Fix Array

* PKG -- [config] Convert @onflow/config to TS (#1731)

* PKG -- [config] Add TypeScript

* Changeset

* fixup

* Remove unnecessary generic from util-actor

* remove non null assertions

---------

Co-authored-by: Alex <[email protected]>

* Fix JSDoc type generation (#1780)

* restore changeset

* align packages

* pre typescript

* any type for config

* update package lock

* Update packages/util-logger/src/util-logger.ts

* fix config type

* use any type

* exit pre

* revert changes to changelogs

---------

Co-authored-by: Jordan Ribbink <[email protected]>
nialexsan added a commit that referenced this pull request Nov 29, 2023
* Nialexsan/add types (#1710)

* switch to uuid from @onflow/utils-uid

* create tsconfigs

* typedefs in ts

* types for actor util

* types for address util

* Revert "switch to uuid from @onflow/utils-uid"

This reverts commit 2a15ef5.

* PKG -- [util-actor] converted to ts

* updated tsconfig

* fixed ts types generation

* Resolve circular dependency

* ts rlp

* change type location

* more types

* build types during regular build

* fix tests

* VSN -- [root] Changeset

* Merge remote-tracking branch 'origin/master' into nialexsan/add-types

* Revert "Resolve circular dependency"

This reverts commit 36efc7d.

* update lock

* VSN -- [root] changeset

* Implement typescript for several branches & adjust configuration (#1750)

Implements typescript support for: @onflow/rlp, @onflow/util-uid, @onflow/util-template, @onflow/util-logger, @onflow/util-invariant, @onflow/util-encode-key, @onflow/util-address

* Convert @onflow/types to TS (#1760)

* [WIP] Convert @onflow/types to TS

* stash

* kind of working

* fix package.json

* fix dictionary

* fix tests

* stash

* strong type tests

* remove any

* rename

* changeset

* PKG -- [util-actor] Enhance TS support (#1761)

* PKG -- [util-actor] Enhance TS support

* rename handlerfnmap

* PKG -- [types] Simplify generics for @onflow/types (#1772)

* PKG -- [types] Simplify generics

* Fix array

* Fix Array

* PKG -- [config] Convert @onflow/config to TS (#1731)

* PKG -- [config] Add TypeScript

* Changeset

* fixup

* Remove unnecessary generic from util-actor

* remove non null assertions

---------

Co-authored-by: Alex <[email protected]>

* Fix JSDoc type generation (#1780)

* restore changeset

* align packages

* pre typescript

* any type for config

* update package lock

* PKG -- [util-encode-key] eslint ts config

* more ts

* move interaction types

* fix types

* more types

* authz types

* fix export

* fix imports

* fixed tests

* fix paths

* fix path

* fix some tests

* clean console log

* fix logic

* addressing PR comments

* fix build arguments

* shallow copy acct

* convert encode

* fix references

* revert changes

* ts resolve signature

* fix resolve accounts and interaction types

* fixed types

* fix path to interactions

* revert changes to changelogs

* fix types for resolve-accounts

* address comments

* changeset

* more descriptive names

* PKG -- [sdk] rename interfaces

* PKG -- [typedefs] fix merge conflict

* PKG -- [typedefs] fix merge conflicts

* PKG -- [sdk] fix interface imports

---------

Co-authored-by: Jordan Ribbink <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] [release-typescript] JSDoc regression
2 participants