PKG -- [fcl-core] Restore onceSealed() resolution behaviour (#2046)

onflow · Dec 16, 2024 · c88f170 · c88f170
1 parent cf583cf
commit c88f170
Show file tree

Hide file tree

Showing 3 changed files with 27 additions and 21 deletions.
diff --git a/.changeset/proud-planes-change.md b/.changeset/proud-planes-change.md
@@ -0,0 +1,5 @@
+---
+"@onflow/fcl-core": patch
+---
+
+Fix bug affecting `fcl.tx(...).onceSealed()`
diff --git a/package-lock.json b/package-lock.json
diff --git a/packages/fcl-core/src/transaction/index.js b/packages/fcl-core/src/transaction/index.js
@@ -150,20 +150,21 @@ export function transaction(
       const suppress = opts.suppress || false
       return new Promise((resolve, reject) => {
         const unsub = subscribe((txStatus, error) => {
-          if (!suppress) {
+          if ((error || txStatus.statusCode) && !suppress) {
             if (error != null) {
               reject(error)
               unsub()
-              return
             } else if (txStatus.statusCode === 1) {
               const transactionError = TransactionError.fromErrorMessage(
                 txStatus.errorMessage
               )
               reject(transactionError)
               unsub()
-              return
             }
-          } else if (predicate(txStatus)) {
+            return
+          }
+
+          if (predicate(txStatus)) {
             resolve(txStatus)
             unsub()
           }