Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add migration contract docs #637

Merged
merged 8 commits into from
Mar 7, 2024
Merged

Add migration contract docs #637

merged 8 commits into from
Mar 7, 2024

Conversation

ianthpun
Copy link
Contributor

@ianthpun ianthpun commented Mar 6, 2024 •
edited
Loading

Add staging migration docs. #624 onflow/flow-cli#1375

@vercel Vercel
Copy link

vercel bot commented Mar 6, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs 🛑 Canceled (Inspect) Mar 7, 2024 9:56pm

jribbink
jribbink reviewed Mar 6, 2024
View reviewed changes
Copy link
Contributor

@jribbink jribbink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just left some comments here for the network used in the examples. Staging will only happen on Testnet & Mainnet, so we shouldn't be using Preview as the example.

@ianthpun ianthpun requested a review from jribbink March 6, 2024 23:25
@bthaile
Copy link
Contributor

bthaile commented Mar 7, 2024

made a few formatting changes to flow command example

bthaile
bthaile approved these changes Mar 7, 2024
View reviewed changes
Copy link
Contributor

@bthaile bthaile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ianthpun ianthpun merged commit 05ca7f5 into main Mar 7, 2024
3 checks passed
@ianthpun ianthpun deleted the ianthpun/migrate-docs branch March 7, 2024 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bthaile bthaile bthaile approved these changes

@chasefleming chasefleming Awaiting requested review from chasefleming

@nialexsan nialexsan Awaiting requested review from nialexsan

@jribbink jribbink Awaiting requested review from jribbink

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ianthpun @bthaile @jribbink