Merge pull request #3216 from onflow/bastian/3214-fix-non-reference-t…

…ype-dereference
onflow · Apr 3, 2024 · 4721725 · 4721725
2 parents 2cb99c1 + 8f30ea1
commit 4721725
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 1 deletion.
diff --git a/runtime/sema/check_unary_expression.go b/runtime/sema/check_unary_expression.go
@@ -83,8 +83,8 @@ func (checker *Checker) VisitUnaryExpression(expression *ast.UnaryExpression) Ty
 						),
 					},
 				)
-				return InvalidType
 			}
+			return InvalidType
 		}
 
 		innerType := referenceType.Type

diff --git a/runtime/tests/checker/reference_test.go b/runtime/tests/checker/reference_test.go
@@ -3546,6 +3546,27 @@ func TestCheckDereference(t *testing.T) {
             `,
 		)
 	})
+
+	runInvalidTestCase(
+		t,
+		"non-reference",
+		`
+          fun test(foo: Int): AnyStruct {
+              return *foo
+          }
+        `,
+	)
+
+	t.Run("invalid type", func(t *testing.T) {
+		t.Parallel()
+
+		_, err := ParseAndCheck(t, `
+          let x = *y
+        `)
+
+		errs := RequireCheckerErrors(t, err, 1)
+		assert.IsType(t, &sema.NotDeclaredError{}, errs[0])
+	})
 }
 
 func TestCheckReferenceRequiredTypeAnnotation(t *testing.T) {
-Original file line number
+Diff line change
@@ Expand Up @@
     						),
     					},
     				)
-    				return InvalidType
     			}
+    			return InvalidType
     		}
     		innerType := referenceType.Type
@@ Expand Down @@