Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[test] Properly setup EVM environment to allow usage of EVM types in test scripts #338

Merged
merged 2 commits into from
Apr 16, 2024
Merged

[test] Properly setup EVM environment to allow usage of EVM types in test scripts #338

merged 2 commits into from
Apr 16, 2024

Conversation

m-Peter
Copy link
Contributor

@m-Peter m-Peter commented Apr 10, 2024

Description

Allow importing the EVM contract in test scripts, so that developers can reference the types defined in this contract.

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@m-Peter m-Peter mentioned this pull request Apr 10, 2024
Merged
6 tasks
@m-Peter m-Peter changed the title [test] Properly setup EVM environment to allow the usage of EVM types in test scripts [test] Properly setup EVM environment to allow usage of EVM types in test scripts Apr 10, 2024
SupunS
SupunS approved these changes Apr 10, 2024
View reviewed changes
Copy link
Member

@SupunS SupunS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 👌

turbolent
turbolent approved these changes Apr 10, 2024
View reviewed changes
Copy link
Member

@turbolent turbolent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice indeed!

test/test_runner.go Outdated Show resolved Hide resolved
@turbolent turbolent added the Improvement Technical work without new features, refactoring, improving tests label Apr 10, 2024
@m-Peter m-Peter force-pushed the setup-evm-environment branch from deb93f1 to e0f8a9b Compare April 16, 2024 06:52
@turbolent turbolent merged commit fe1e785 into onflow:master Apr 16, 2024
6 checks passed
@m-Peter m-Peter deleted the setup-evm-environment branch April 16, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turbolent turbolent turbolent approved these changes

@SupunS SupunS SupunS approved these changes

@dsainati1 dsainati1 Awaiting requested review from dsainati1

Assignees
No one assigned
Labels
Improvement Technical work without new features, refactoring, improving tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@m-Peter @turbolent @SupunS