Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[LS] Add string import resolver to WASM LS #228

Merged
merged 3 commits into from
Oct 26, 2023
Merged

[LS] Add string import resolver to WASM LS #228

merged 3 commits into from
Oct 26, 2023

Conversation

jribbink
Copy link
Contributor

@jribbink jribbink commented Oct 25, 2023 •
edited
Loading

closes #168

Description

Adds StringImportResolver support to WASM LS. Needed for new import syntax.

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@jribbink jribbink marked this pull request as draft October 25, 2023 18:37
@jribbink jribbink marked this pull request as ready for review October 25, 2023 18:54
@jribbink jribbink changed the title [LS] Add StringImportResolver to WASM LS [LS] Add string import resolver to WASM LS Oct 25, 2023
turbolent
turbolent approved these changes Oct 25, 2023
View reviewed changes
Copy link
Member

@turbolent turbolent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

SupunS
SupunS approved these changes Oct 25, 2023
View reviewed changes
Copy link
Member

@SupunS SupunS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Is it possible to add a test for the added functionality?

@jribbink
Copy link
Contributor Author

jribbink commented Oct 26, 2023 •
edited
Loading

Looks good! Is it possible to add a test for the added functionality?

It's a bit tricky because there's no integration tests for WASM build currently (I think that's probably the way to go about this?). I think this is its own PR in and of itself.

@turbolent turbolent merged commit 846cd46 into master Oct 26, 2023
@turbolent turbolent deleted the jribbink/string-import-wasm branch October 26, 2023 22:34
This was referenced Nov 14, 2023
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SupunS SupunS SupunS approved these changes

@turbolent turbolent turbolent approved these changes

@dsainati1 dsainati1 Awaiting requested review from dsainati1

Assignees
No one assigned
Labels
Feature Language Server
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[LS] Support New Import Syntax
3 participants
@jribbink @turbolent @SupunS