Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[LS] Implement ReadRandom for standardLibrary type #218

Merged
merged 1 commit into from
Oct 3, 2023
Merged

[LS] Implement ReadRandom for standardLibrary type #218

merged 1 commit into from
Oct 3, 2023

Conversation

m-Peter
Copy link
Contributor

@m-Peter m-Peter commented Oct 3, 2023

Description

Proactive addition for the breaking change introduced in onflow/cadence@b1ca6fa

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@m-Peter
Copy link
Contributor Author

m-Peter commented Oct 3, 2023

Note: Upon version bump of the onflow/cadence dependency, the UnsafeRandom can be removed entirely.

turbolent
turbolent approved these changes Oct 3, 2023
View reviewed changes
Copy link
Member

@turbolent turbolent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for being pro-active about this 👍

@turbolent turbolent self-assigned this Oct 3, 2023
@turbolent turbolent added the Improvement Technical work without new features, refactoring, improving tests label Oct 3, 2023
@turbolent turbolent merged commit 70f75c6 into onflow:master Oct 3, 2023
7 checks passed
@m-Peter m-Peter deleted the stdlib-add-read-random branch October 4, 2023 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turbolent turbolent turbolent approved these changes

@SupunS SupunS Awaiting requested review from SupunS SupunS is a code owner

@dsainati1 dsainati1 Awaiting requested review from dsainati1

Assignees

@turbolent turbolent

Labels
Improvement Technical work without new features, refactoring, improving tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@m-Peter @turbolent