Add ability to skip files based on extension. #695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should also resolve #600 without having a blanket filtering of |
This was
linked to
issues
Dec 24, 2023
e3krisztian
reviewed
Jan 2, 2024
qkaiser
force-pushed
the
skip-extension
branch
from
db0b0a0 to
ffbb9f3
Compare
e3krisztian
approved these changes
Jan 3, 2024
There was a problem hiding this comment.
Neat!
For the record:
- there is a built in set of extensions to skip on
- user specified extensions overwrite the built in set
- empty extension is supported, which would result in skipping extraction of files without extension
- giving an invalid extension (not empty, and does not start with
.) will disable the builtin extension skip list
- there is a built in set of extensions to skip on - user specified extensions overwrite the built in set - empty extension is supported, which would result in skipping extraction of files without extension - giving an invalid extension (not empty, and does not start with .) will disable the builtin extension skip list Co-authored-by: Krisztián Fekete <[email protected]>
qkaiser
force-pushed
the
skip-extension
branch
from
ffbb9f3 to
d234764
Compare
|
Edited the commit message to include the bullet points listed by @e3krisztian |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As indicated in #647, the ability to skip files from being processed based on their extension seems to be the right approach.