Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve unblob "skip-extraction" mode of operation #692

Merged
merged 4 commits into from
Jan 3, 2024

Conversation

qkaiser
Copy link
Contributor

@qkaiser qkaiser commented Dec 24, 2023

The following improvements have been made in order to let user simply "scan" a file:

  1. do not create the root level extraction dir when executed with the --skip-extraction option.
  2. display a summary of identified chunks when executed with the --skip-extraction option.

This is related to #624.

Right now the information displayed to the user is fairly limited:

image

But the introduction of metadata reporting in chunks (see #557) would allow us to display detailed information in the "description" column, such as endianness, version, compression, block size, creation size, etc.

@aserper
Copy link

aserper commented Dec 24, 2023

Makes sense and looks good! 👍

@qkaiser qkaiser linked an issue Dec 24, 2023 that may be closed by this pull request
Copy link
Contributor

@e3krisztian e3krisztian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thinks this is fine as is (only code reordering proposed), however there is no test for skip_extraction at all, so future changes could inadvertently break the newly added functionality.

unblob/cli.py Outdated Show resolved Hide resolved
unblob/processing.py Outdated Show resolved Hide resolved
@qkaiser qkaiser force-pushed the ui-no-extract-report branch from 8a0df96 to 2895922 Compare January 2, 2024 17:36
@qkaiser
Copy link
Contributor Author

qkaiser commented Jan 2, 2024

@e3krisztian I applied your recommendations, introduced tests for both the cli and processing parts of skip_extraction option and fixed a typo in the CLI (skip_extraction should have been skip-extraction from the beginning).

Copy link
Contributor

@e3krisztian e3krisztian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! :)

@qkaiser qkaiser force-pushed the ui-no-extract-report branch from 2895922 to d1b6ccc Compare January 3, 2024 12:03
@qkaiser qkaiser enabled auto-merge January 3, 2024 12:04
@qkaiser qkaiser merged commit 00b25fa into main Jan 3, 2024
16 checks passed
@qkaiser qkaiser deleted the ui-no-extract-report branch January 3, 2024 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add option to only "scan" the binary like binwalk would do for example
3 participants