-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve unblob "skip-extraction" mode of operation #692
Conversation
Makes sense and looks good! 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thinks this is fine as is (only code reordering proposed), however there is no test for skip_extraction
at all, so future changes could inadvertently break the newly added functionality.
8a0df96
to
2895922
Compare
@e3krisztian I applied your recommendations, introduced tests for both the cli and processing parts of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool! :)
…aunched with --skip-extraction.
Co-authored-by: Krisztián Fekete <[email protected]>
2895922
to
d1b6ccc
Compare
The following improvements have been made in order to let user simply "scan" a file:
--skip-extraction
option.--skip-extraction
option.This is related to #624.
Right now the information displayed to the user is fairly limited:
But the introduction of metadata reporting in chunks (see #557) would allow us to display detailed information in the "description" column, such as endianness, version, compression, block size, creation size, etc.