processing: extract progress reporting from business logic #680
+115
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vlaci
force-pushed
the
refactor-progress-reporting
branch
2 times, most recently
from
72fae3a to
00982e0
Compare
While trying to update pyright, it started complaining about
potentially unbound variables[^1]. These are not actual correctness
issues, but signals some code smell due to conditionally configured
variables.
The progress bar handling got extracted from `_process_task`, and got
converted to a context manager, so its lifetime management became
simpler. To eliminate if conditions sprinkled everywhere, a
`NullProgressDisplay` is also added for the case where we want to do
nothing.
[^1]:
```
/home/vlaci/devel/git/github.com/onekey-sec/unblob/unblob/processing.py
/home/vlaci/devel/git/github.com/onekey-sec/unblob/unblob/processing.py:163:36 - error: "progress_display" is possibly unbound (reportUnboundVariable)
/home/vlaci/devel/git/github.com/onekey-sec/unblob/unblob/processing.py:164:13 - error: "progress_display" is possibly unbound (reportUnboundVariable)
/home/vlaci/devel/git/github.com/onekey-sec/unblob/unblob/processing.py:165:17 - error: "overall_progress_task" is possibly unbound (reportUnboundVariable)
/home/vlaci/devel/git/github.com/onekey-sec/unblob/unblob/processing.py:167:23 - error: "progress_display" is possibly unbound (reportUnboundVariable)
/home/vlaci/devel/git/github.com/onekey-sec/unblob/unblob/processing.py:184:9 - error: "progress_display" is possibly unbound (reportUnboundVariable)
/home/vlaci/devel/git/github.com/onekey-sec/unblob/unblob/processing.py:184:38 - error: "overall_progress_task" is possibly unbound (reportUnboundVariable)
/home/vlaci/devel/git/github.com/onekey-sec/unblob/unblob/processing.py:185:9 - error: "progress_display" is possibly unbound (reportUnboundVariable)
7 errors, 0 warnings, 0 informations
```
vlaci
force-pushed
the
refactor-progress-reporting
branch
from
00982e0 to
9d940c8
Compare
|
Nice! :) |
e3krisztian
approved these changes
Nov 14, 2023
qkaiser
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While trying to update pyright, it started complaining about potentially unbound variables1. These are not actual correctness issues, but signals some code smell due to conditionally configured variables.
The progress bar handling got extracted from
_process_task, and got converted to a context manager, so its lifetime management became simpler. To eliminate if conditions sprinkled everywhere, aNullProgressDisplayis also added for the case where we want to do nothing.Footnotes