Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ci): use macos-14 in build-nix. #1013

Merged
merged 1 commit into from
Dec 4, 2024
Merged

feat(ci): use macos-14 in build-nix. #1013

merged 1 commit into from
Dec 4, 2024

Conversation

qkaiser
Copy link
Contributor

@qkaiser qkaiser commented Nov 22, 2024

macos-12 runner are getting phased out, time to update

@qkaiser qkaiser requested a review from vlaci November 22, 2024 10:58
@qkaiser qkaiser self-assigned this Nov 22, 2024
@qkaiser qkaiser linked an issue Nov 22, 2024 that may be closed by this pull request
@vlaci
Copy link
Contributor

vlaci commented Nov 22, 2024

hmm, how macos-14 on M1 works with x86_64? Does it go through rosetta?

@qkaiser
Copy link
Contributor Author

qkaiser commented Nov 22, 2024

hmm, how macos-14 on M1 works with x86_64? Does it go through rosetta?

I think they run macos-14 on Intel based runners (maybe Mac Mini or similar) when you set the arch to x86_64.

@qkaiser qkaiser added the CI/CD Pull request that updates our Github CI/CD label Nov 29, 2024
@qkaiser
Copy link
Contributor Author

qkaiser commented Dec 3, 2024

@vlaci anything else ?

@qkaiser qkaiser requested review from kukovecz and removed request for vlaci December 4, 2024 08:36
@vlaci vlaci self-requested a review December 4, 2024 11:55
@vlaci vlaci force-pushed the 1011-mac-runner-fix branch from 7cb6984 to 6082974 Compare December 4, 2024 11:55
@vlaci vlaci enabled auto-merge December 4, 2024 11:55
@vlaci vlaci merged commit 495e351 into main Dec 4, 2024
15 checks passed
@vlaci vlaci deleted the 1011-mac-runner-fix branch December 4, 2024 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/CD Pull request that updates our Github CI/CD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

macos-12 runner is deprecated
2 participants