Update OS provider config API #925
Open
+1,142
−296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinser52
force-pushed
the
svinogra_os_params
branch
2 times, most recently
from
37132e1
to
283b26f
Compare
vinser52
force-pushed
the
svinogra_os_params
branch
from
283b26f
to
4d0a4a5
Compare
scripts/docs_config/examples.rst
Outdated
|
|
||
| umf_memory_provider_ops_t *provider_ops = umfOsMemoryProviderOps(); | ||
| umf_os_memory_provider_params_t params = umfOsMemoryProviderParamsDefault(); | ||
|
|
||
| Get a default memory provider parameters. The handle to the parameters object |
There was a problem hiding this comment.
Get default OS memory...
| &os_memory_provider); | ||
| umfOsMemoryProviderParamsDestroy(os_params); |
There was a problem hiding this comment.
we could also check return value of this func
There was a problem hiding this comment.
yeah, but what we should do with that? It does not impact the benchamrk. As you can see below we also do not check the return of the umfMemoryProviderDestroy
vinser52
force-pushed
the
svinogra_os_params
branch
3 times, most recently
from
55da957
to
2ab852c
Compare
vinser52
force-pushed
the
svinogra_os_params
branch
from
2ab852c
to
7f84ae8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Change the L0 provider config as we agreed in #844
Checklist