[SPARSE] Add support for rocSPARSE backend #544
Conversation
Rbiessy
changed the title
|
Tests log on W6800: amd_w6800_log.txt |
gajanan-choudhary
added
backend
|
Yes, this is in progress! I expect I will need a few days at least. I'm aiming to merge the PR by the end of the year. |
Rbiessy
force-pushed
the
romain/rocsparse
branch
from
af87004
to
c4b952c
Compare
|
@gajanan-choudhary I have updated the PR with recent changes from cuSPARSE. Note that it moved almost all the content from |
| <td align="center">AMD GPU</td> | ||
| </tr> | ||
| <tr> | ||
| <td align="center"><a href="https://github.com/ROCmSoftwarePlatform/rocSPARSE"> AMD rocSPARSE</a></td> |
There was a problem hiding this comment.
Please also add rocSPARSE version info in the table later in this README file in the table in the Product and Version Information section
There was a problem hiding this comment.
Thanks for catching that, done in dc22051
| - The same sparse matrix handle cannot be reused for multiple operations | ||
| ``spmm``, ``spmv``, or ``spsv``. Doing so will throw a | ||
| ``oneapi::mkl::unimplemented`` exception. See `#332 | ||
| <https://github.com/ROCm/rocSPARSE/issues/332>`_. |
There was a problem hiding this comment.
Wow, this is quite severe, but seems to be a legitimate issue on rocSPARSE side right now.
There was a problem hiding this comment.
If and when they fix this issue, though, will it be easy for us to make changes (with a version check of course) that correctly performs the operations rather than throwing an unimplemented exception?
There was a problem hiding this comment.
Yes, it's easy to fix on oneMath side. The issue is also referenced in this comment: https://github.com/oneapi-src/oneMKL/pull/544/files#diff-3b8c1c2c71abd54f8f90f43415c2f17b2a7fdb81c2b882c210f3cba56b4679adR63
One would just need to remove the used member, its 2 usages below as well as the mark_used method.
| @@ -22,6 +22,7 @@ | |||
| #include "cusparse_error.hpp" | |||
| #include "cusparse_helper.hpp" | |||
| #include "cusparse_handles.hpp" | |||
| #include "cusparse_scope_handle.hpp" | |||
There was a problem hiding this comment.
Why is a cuSPARSE change coming in here?
There was a problem hiding this comment.
Is it related to the common_launch_task.hpp to keep common code between cuSPARSE and rocSPARSE backends?
There was a problem hiding this comment.
It's just as you said, cusparse_task.hpp used to include cusparse_scope_handle.hpp but it's not needed anymore (with the already merged changes to use the ScopeHandle object less often) and not possible anymore with the introduction of the more generic common_launch_task.hpp.
| #include "rocsparse_error.hpp" | ||
| #include "sparse_blas/backends/common_launch_task.hpp" | ||
|
|
||
| namespace oneapi::mkl::sparse::rocsparse::detail { |
There was a problem hiding this comment.
Other than cusparse -> rocsparse, this file, rocsparse/rocsparse_task.hpp appears to be nearly identical to cusparse/cusparse_task.hpp. Is there anything more than that in this file?
There was a problem hiding this comment.
Yes, they are almost identical. I'm not sure I understand, why do you ask?
Description
Add support for the rocSPARSE backend.
Depends on #527 and #532.
Rendered docs: docs.zip
Checklist
All Submissions
Do all unit tests pass locally? amd_log.txt nvidia_log.txt intel_log.txt
Have you formatted the code using clang-format?