Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cpu: aarch64: Re-enable ACL indirect conv for BF16 #2218

Merged
merged 1 commit into from
Nov 20, 2024
Merged

cpu: aarch64: Re-enable ACL indirect conv for BF16 #2218

merged 1 commit into from
Nov 20, 2024

Conversation

fadara01
Copy link
Contributor

@fadara01 fadara01 commented Nov 18, 2024 •
edited by Sqvid
Loading

Description

cpu: aarch64: Re-enable ACL indirect conv for BF16

Fixes change caused by c547c77

Checklist

General

  • [ Y ] Do all unit and benchdnn tests (make test and make test_benchdnn_*) pass locally for each commit?
  • [ Y ] Have you formatted the code using clang-format?

Performance improvements

  • Have you submitted performance data that demonstrates performance improvements?

New features

  • Have you published an RFC for the new feature?
  • Was the RFC approved?
  • Have you added relevant tests?

Bug fixes

  • Have you included information on how to reproduce the issue (either in a github issue or in this PR)?
  • Have you added relevant regression tests?

RFC PR

  • Does RFC document follow the template?
  • Have you added a link to the rendered document?

@fadara01 fadara01 requested a review from a team as a code owner November 18, 2024 14:42
@fadara01
Copy link
Contributor Author

fadara01 commented Nov 18, 2024 •
edited
Loading

@theComputeKid @jondea @milpuz01

@theComputeKid
Copy link
Contributor

@fadara01 could you update the PR with the commit that caused the issue?

@Sqvid Sqvid added the platform:cpu-aarch64 Codeowner: @oneapi-src/onednn-cpu-aarch64 label Nov 19, 2024
@theComputeKid
Copy link
Contributor

cc: @vpirogov could we merge please?

@vpirogov vpirogov merged commit 42b0d5c into oneapi-src:main Nov 20, 2024
24 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theComputeKid theComputeKid theComputeKid approved these changes

@Radu2k Radu2k Radu2k approved these changes

Assignees
No one assigned
Labels
platform:cpu-aarch64 Codeowner: @oneapi-src/onednn-cpu-aarch64
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@fadara01 @theComputeKid @Radu2k @vpirogov @Sqvid