Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aarch64: reorder: add Acdb8a/Acdb4a and check for SVE availability when necessary #1828

Merged
merged 1 commit into from
Mar 14, 2024

Conversation

renato-arantes
Copy link
Contributor

Description

  1. It fixes the test_reorder test by checking whether the target supports SVE instructions before executing a reorder that uses SVE intrinsics.
  2. It also adds Acdb8a and Acdb4a formats to the possible target reorder memory formats.

General

  • Do all unit and benchdnn tests (make test and make test_benchdnn_*) pass locally for each commit?
  • Have you formatted the code using clang-format?

@mgouicem
Copy link
Contributor

mgouicem commented Mar 13, 2024

Thanks @renato-arantes.

  • Could you run clang format on your patch please?
  • could you change the commit message to adhere to oneDNN contribution guidelines ? Something like aarch64: reorder: add Acdb8a/Acdb4a and check for SVE availability when necessary should do

@renato-arantes renato-arantes changed the title Fixes test_reorder and adds Acdb8a/Acdb4a reorder target formats. aarch64: reorder: add Acdb8a/Acdb4a and check for SVE availability when necessary Mar 13, 2024
@vpirogov vpirogov added this to the v3.5 milestone Mar 14, 2024
@mgouicem mgouicem merged commit 30f5852 into oneapi-src:main Mar 14, 2024
10 checks passed
@vpirogov vpirogov added the platform:cpu-aarch64 Codeowner: @oneapi-src/onednn-cpu-aarch64 label May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform:cpu-aarch64 Codeowner: @oneapi-src/onednn-cpu-aarch64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants