Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SYCLomatic] Avoid migration of non-CUDA type "half" #2498

Open
wants to merge 11 commits into
base: SYCLomatic
Choose a base branch
from
Open

[SYCLomatic] Avoid migration of non-CUDA type "half" #2498

wants to merge 11 commits into from
+86 −1

Conversation

the-slow-one
Copy link
Collaborator

Problem: half defined in a location outside of source under investigation and outside of CUDA header is migrated to sycl::half.

This PR prevents such migration.

@the-slow-one the-slow-one requested a review from a team as a code owner November 19, 2024 12:23
zhiweij1
zhiweij1 requested changes Nov 20, 2024
View reviewed changes
Copy link
Contributor

@zhiweij1 zhiweij1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a lit test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhimingwang36 zhimingwang36 Awaiting requested review from zhimingwang36 zhimingwang36 is a code owner automatically assigned from oneapi-src/syclomatic-reviewers

@zhiweij1 zhiweij1 Awaiting requested review from zhiweij1

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@the-slow-one @zhiweij1