Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #32 ( https://github.com/oncleben31/ha-pool_pump/issues/32 ) #5

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

roumano
Copy link

@roumano roumano commented Sep 27, 2023

Fixing issue #32 Bug for Filtration time, impossible to use more than ~17h

Tested with input_number.pool_water_temperature : 32

Log output of the custom_compoment ( splitting to several ligne for better visibility here )

Sep 27 14:56:25 pi hass[286052]: 2023-09-27 14:56:25.659 DEBUG (MainThread) [custom_components.pool_pump] Manager initialised: <PoolPumpManager(runs=[
<Run(
  start=2023-09-27 00:09:28.908000+02:00,
  stop=2023-09-27 13:27:59.908000+02:00,
   duration=13.30861111111111)>, 
<Run(
  start=2023-09-27 13:28:00+02:00,
  stop=2023-09-27 23:59:59+02:00,
  duration=10.533055555555556)>])>

Of course first_duration = self._total_duration / 3 and second_duration = 2 * first_duration can't be used on these high level of temperature

@roumano
Copy link
Author

roumano commented Oct 5, 2023

Can you review my merge request?
Regards

1 similar comment
@roumano
Copy link
Author

roumano commented Dec 17, 2023

Can you review my merge request?
Regards

@roumano
Copy link
Author

roumano commented Apr 22, 2024

Hi,
It's frustrating to not get news since several months

Can you review my merge request ?
Regards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant