Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update gno docs link url #591

Merged
merged 1 commit into from
Sep 26, 2024
Merged

Conversation

jinoosss
Copy link
Member

What type of PR is this?

  • chore

What this PR does:

@jinoosss jinoosss requested a review from a team as a code owner September 26, 2024 03:08
@jinoosss jinoosss merged commit f98130b into main Sep 26, 2024
2 checks passed
@jinoosss jinoosss deleted the chore/update-gno-docs-link-url branch September 26, 2024 03:21
@@ -6,5 +6,5 @@ export const ADENA_SETUP_AIRGAP_HELP_PAGE =
export const HARDWARE_WALLET_LEARN_PAGE =
'https://docs.adena.app/user-guide/sign-in/connect-hardware-wallet' as const;
export const GNO_CLI_HELP_PAGE =
'https://docs.gno.land/getting-started/local-setup/working-with-key-pairs' as const;
'https://docs.gno.land/gno-tooling/cli/gnokey/working-with-key-pairs' as const;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It can be sketchy to hardcode something like this, but just to keep in mind we should probably point it to a shortened URL we can change

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll try to figure out a way to make it manageable.
Environment variables, static files, remotes, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants