Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix bugs during multiple mnemonics processing #587

Merged
merged 4 commits into from
Sep 26, 2024
Merged

fix: fix bugs during multiple mnemonics processing #587

merged 4 commits into from
Sep 26, 2024

Conversation

jinoosss
Copy link
Member

What type of PR is this?

  • bug

What this PR does:

  • Shows the account address without omitting any characters.
  • When adding an account to an existing mnemonic, skip the prompts.
  • Fix the UI to be centred during the account selection process.
  • Fixes a bug that prevented updating accounts by mnemonic when selecting an account.

@jinoosss jinoosss added the bug Something isn't working label Sep 26, 2024
@jinoosss jinoosss requested a review from a team as a code owner September 26, 2024 01:50
@jinoosss jinoosss merged commit 5ab7148 into main Sep 26, 2024
2 checks passed
@jinoosss jinoosss deleted the ADN-619-fix-bugs-during-multiple-mnemonics-processing branch September 26, 2024 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dongwon8247 dongwon8247 dongwon8247 approved these changes

@onlyhyde onlyhyde Awaiting requested review from onlyhyde onlyhyde is a code owner automatically assigned from onbloc/core-engineers

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jinoosss @dongwon8247