Secure signature-policy default and options #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set the default signature-policy to require-signatures because software update mechanisms need to be secure. Remove the verify option because it provides zero security, can't implement policy, and the name is incredibly misleading. Any attacker who can modify the repo, either by MITM or access to the repo server, just needs to remove the signature from the manifest to be able alter a package. Users currently using 'verify' should be honest about it and use 'ignore'.
|
Not accepting this for '014, but keeping it as fodder for a future release. |
|
I agree it may be too big a step for the forthcoming release. But I have hope for the future. :-) |
|
+1 on this change, 'verify' is worse than useless because it can provide a false sense of security. Although if require-signatures is made the default for new publishers, will that break third party repos unless they specify ignore? |
|
It will break 3rd-party repos unless they specify ignore. This is why I haven't pulled this in yet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set the default signature-policy to require-signatures because software update mechanisms need to be secure.
Remove the verify option because it provides zero security, can't implement policy, and the name is incredibly misleading. Any attacker who can modify the repo, either by MITM or access to the repo server, just needs to remove the signature from the manifest to be able alter a package.
Users currently using 'verify' should be honest about it and use 'ignore'.