refactor ⚙: Refactoring the confirmDeployment flow

omnia-network · Jun 19, 2024 · 51fe8a4 · 51fe8a4
1 parent a873f77
commit 51fe8a4
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 6 deletions.
diff --git a/frontend/app/dashboard/new-deployment/page.tsx b/frontend/app/dashboard/new-deployment/page.tsx
@@ -19,7 +19,7 @@ import {displayE8sAsIcp, icpToE8s} from "@/helpers/ui";
 import {Spinner} from "@/components/spinner";
 import {NewDeploymentForm} from "@/components/new-deployment-form";
 import {transferE8sToBackend} from "@/services/backend";
-import {sendManifestToProviderFlow} from "@/services/deployment";
+import {confirmDeployment} from "@/services/deployment";
 
 const FETCH_DEPLOYMENT_PRICE_INTERVAL_MS = 30_000; // 30 seconds
 
@@ -163,7 +163,7 @@ export default function NewDeployment() {
             el.hasOwnProperty("DeploymentCreated")
           )!;
 
-          await sendManifestToProviderFlow(
+          await confirmDeployment(
             deploymentUpdate.update,
             deploymentCreatedState,
             tlsCertificateData!

diff --git a/frontend/app/dashboard/page.tsx b/frontend/app/dashboard/page.tsx
@@ -31,7 +31,7 @@ import {
   isDeploymentFailed,
 } from "@/helpers/deployment";
 import {displayIcp} from "@/helpers/ui";
-import {queryLeaseStatus, sendManifestToProviderFlow} from "@/services/deployment";
+import {confirmDeployment, queryLeaseStatus} from "@/services/deployment";
 import {DeploymentTier} from "@/types/deployment";
 import {ChevronsUpDown} from "lucide-react";
 import {useRouter} from "next/navigation";
@@ -131,7 +131,7 @@ export default function Dashboard() {
         try {
           const cert = await loadOrCreateCertificate(backendActor!);
 
-          await sendManifestToProviderFlow(
+          await confirmDeployment(
             lastState,
             deploymentCreatedState,
             cert!
@@ -147,8 +147,10 @@ export default function Dashboard() {
               stepActive
             )
           );
+
+          await fetchDeployments(backendActor!);
         } catch (e) {
-          console.error(e);
+          console.error("Failed to update deployment:", e);
         }
       }
     }

diff --git a/frontend/services/deployment.ts b/frontend/services/deployment.ts
@@ -77,7 +77,7 @@ export const queryLeaseStatus = async (queryLeaseUrl: string, certData: X509Cert
   return await res.json();
 };
 
-export const sendManifestToProviderFlow = async (deploymentState: DeploymentState, deploymentCreatedState: DeploymentState, cert: MTlsCertificateData) => {
+export const confirmDeployment = async (deploymentState: DeploymentState, deploymentCreatedState: DeploymentState, cert: MTlsCertificateData) => {
   try {
     if ("LeaseCreated" in deploymentState) {
       const {manifest_sorted_json, dseq} = extractDeploymentCreated(deploymentCreatedState);
@@ -94,6 +94,7 @@ export const sendManifestToProviderFlow = async (deploymentState: DeploymentStat
         manifest_sorted_json,
         cert!
       );
+
     } else {
       throw new Error("Deployment state is not in LeaseCreated state");
     }