Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(contracts/core): improved FeeOracleV2 update efficiency #2537

Merged
merged 8 commits into from
Nov 29, 2024

Conversation

Zodomo
Copy link
Contributor

@Zodomo Zodomo commented Nov 21, 2024

Refactored FeeOracleV2 such that data cost fee updates can be made once and update all execution layer pricing for all chains that post to any given data layer. Also, conversion rates are set independently, which updates pricing for all routes that rely on them.

issue: #1951

@Zodomo Zodomo self-assigned this Nov 21, 2024
contracts/core/src/interfaces/IFeeOracleV2.sol Outdated Show resolved Hide resolved
contracts/core/src/interfaces/IFeeOracleV2.sol Outdated Show resolved Hide resolved
contracts/core/src/xchain/FeeOracleV2.sol Outdated Show resolved Hide resolved
contracts/core/src/xchain/FeeOracleV2.sol Outdated Show resolved Hide resolved
contracts/core/src/interfaces/IFeeOracleV2.sol Outdated Show resolved Hide resolved
lib/contracts/feeoraclev2/config.go Outdated Show resolved Hide resolved
contracts/core/src/interfaces/IFeeOracleV2.sol Outdated Show resolved Hide resolved
contracts/core/src/interfaces/IFeeOracleV2.sol Outdated Show resolved Hide resolved
lib/contracts/feeoraclev2/config.go Show resolved Hide resolved
lib/contracts/feeoraclev2/config.go Outdated Show resolved Hide resolved
Copy link
Contributor

@kevinhalliday kevinhalliday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌 👏

@Zodomo Zodomo merged commit 1e69efc into main Nov 29, 2024
20 checks passed
@Zodomo Zodomo deleted the zodomo/update-feeoraclev2 branch November 29, 2024 15:25
chmllr pushed a commit that referenced this pull request Dec 3, 2024
Refactored FeeOracleV2 such that data cost fee updates can be made once 
and update all execution layer pricing for all chains that post to any given 
data layer. Also, conversion rates are set independently, which updates pricing
for all routes that rely on them.

issue: #1951
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants