Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(e2e/admin): added portal fee oracle upgrade action #2522

Merged
merged 3 commits into from
Dec 2, 2024

Conversation

Zodomo
Copy link
Contributor

@Zodomo Zodomo commented Nov 20, 2024

This adds an admin command to upgrade the feeOracle address on the OmniPortal contracts to the FeeOracleV2 address.

issue: #1951

contracts/core/script/admin/Admin.s.sol Outdated Show resolved Hide resolved
Copy link
Contributor

@kevinhalliday kevinhalliday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe let's call this comething other than upgrade, we use upgrade a lot to refer to proxy upgrades. Maybe update or set? or something else

@Zodomo Zodomo force-pushed the zodomo/upgrade-portal-oracle branch from b22cf29 to 74befd5 Compare November 29, 2024 15:34
Copy link
Contributor

@kevinhalliday kevinhalliday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@Zodomo Zodomo merged commit 54f3e71 into main Dec 2, 2024
19 checks passed
@Zodomo Zodomo deleted the zodomo/upgrade-portal-oracle branch December 2, 2024 23:26
chmllr pushed a commit that referenced this pull request Dec 3, 2024
This adds an admin command to upgrade the `feeOracle` address on the
OmniPortal contracts to the FeeOracleV2 address.

issue: #1951
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants