Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lib/contracts): correct deployment of feeoraclev2 #2507

Merged
merged 3 commits into from
Nov 19, 2024

Conversation

Zodomo
Copy link
Contributor

@Zodomo Zodomo commented Nov 18, 2024

Generation of FeeParams for L2 Sepolia testnets was failing as Sepolia isn't in the manifests for staging or omega. Default gas prices to 1 gwei for non-mainnet manifests.

issue: #1951

Copy link
Contributor

@kevinhalliday kevinhalliday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do this just for mainnet? Can we just stub a 1 gwei gas price if we don't find the backend for the chain (i.e sepola)

@Zodomo Zodomo merged commit e40b358 into main Nov 19, 2024
19 checks passed
@Zodomo Zodomo deleted the zodomo/feeoraclev2-deployer branch November 19, 2024 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants