feat(e2s): add RoleTester service account key for mainnet part 1 #2352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add new key type for "service" keys or keys not used for anything protocol or stack related - map RoleTester to mainnet service key to be used for test mainnet app
kc1116
requested review from
corverroos,
sideninja,
chmllr and
kevinhalliday
as code owners
|
Currently the key generation tool assumes that all keys being created for a application service. This PR adds the We generated a new service key for mainnet and mapped it to the RoleTester. Now we can access this key in the e2e app the same way we access RoleTester for other networks. |
chmllr
approved these changes
Nov 1, 2024
sideninja
reviewed
Nov 1, 2024
| @@ -46,5 +46,6 @@ var statics = map[netconf.ID][]Account{ | |||
| remote("0x9496Bf1Bd2Fa5BCba72062cC781cC97eA6930A13", RoleDeployer), | |||
| secret("0xfD62020Cee216Dc543E29752058Ee9f60f7D9Ff9", RoleMonitor), | |||
| secret("0x6191442101086253A636aecBCC870e4778490AaB", RoleRelayer), | |||
| secret("0x84aC7eeC1e035Fa13a7DEBD5f6da69B82CBDC5B5", RoleTester), | |||
There was a problem hiding this comment.
wouldn't it be better for this account to be remote type, managed by Fireblocks?
corverroos
reviewed
Nov 1, 2024
| @@ -22,14 +22,15 @@ const ( | |||
| P2PConsensus Type = "p2p_consensus" | |||
| P2PExecution Type = "p2p_execution" | |||
| EOA Type = "eoa" | |||
| Service Type = "service" | |||
There was a problem hiding this comment.
no need for a new type, this is an eoa
corverroos
reviewed
Nov 1, 2024
| @@ -4,6 +4,9 @@ public_chains = ["ethereum","arbitrum_one","base","optimism"] | |||
| multi_omni_evms = true | |||
| prometheus = true | |||
|
|
|||
| [keys.tester] | |||
There was a problem hiding this comment.
don't think this is the way to go, it deplicates whatever is in the eoa package. Follow the same patterns as relayer and monitor keys.
corverroos
requested changes
Nov 1, 2024
|
Did not have to do. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a RoleTester key for mainnet so that we can submit xmsgs to mainnet via a script.
issue: #2275