chore(deps): bump github.com/ethereum/go-ethereum from 1.14.8 to 1.14.11 #2026
Conversation
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
Bumps [github.com/ethereum/go-ethereum](https://github.com/ethereum/go-ethereum) from 1.14.8 to 1.14.11. - [Release notes](https://github.com/ethereum/go-ethereum/releases) - [Commits](ethereum/go-ethereum@v1.14.8...v1.14.11) --- updated-dependencies: - dependency-name: github.com/ethereum/go-ethereum dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
- Added DiscoveryV5 = true to golden files to match the updated output of dumpconfig from the updated geth version. Note: geth sets DiscoveryV4 = True and DiscoveryV5 = true in the default configs see https://github.com/ethereum/go-ethereum/blob/master/cmd/utils/flags.go#L1366-L1367 for nodes not runing V5 backwards compatibility - updated all references of v1.14.8 -> v1.14.11
| @@ -106,7 +106,8 @@ func MakeGethConfig(conf Config) FullConfig { | |||
|
|
|||
| // Set the bootnodes and trusted nodes. | |||
| cfg.Node.UserIdent = conf.Moniker | |||
| cfg.Node.P2P.DiscoveryV4 = true // TODO(corver): Switch to v5. | |||
| cfg.Node.P2P.DiscoveryV4 = true | |||
| cfg.Node.P2P.DiscoveryV5 = true | |||
There was a problem hiding this comment.
Is enabling both safe / is this necessary for 1.14.11?
There was a problem hiding this comment.
indeed, this require a separate issue with dedicated P2P testing
…-ethereum-1.14.11
- Disables discv5 which is enabled by default since geth version 1.14.9 to limit scope of PR - add unittest-run to makefile
| @@ -106,7 +106,8 @@ func MakeGethConfig(conf Config) FullConfig { | |||
|
|
|||
| // Set the bootnodes and trusted nodes. | |||
| cfg.Node.UserIdent = conf.Moniker | |||
| cfg.Node.P2P.DiscoveryV4 = true // TODO(corver): Switch to v5. | |||
| cfg.Node.P2P.DiscoveryV4 = true | |||
| cfg.Node.P2P.DiscoveryV5 = true | |||
There was a problem hiding this comment.
indeed, this require a separate issue with dedicated P2P testing
| @@ -17,7 +17,8 @@ | |||
| "shanghaiTime": 0, | |||
| "cancunTime": 0, | |||
| "terminalTotalDifficulty": 0, | |||
| "terminalTotalDifficultyPassed": true | |||
| "terminalTotalDifficultyPassed": true, | |||
| "depositContractAddress": "0x0000000000000000000000000000000000000000" | |||
There was a problem hiding this comment.
are we sure this is fine?
There was a problem hiding this comment.
Yes this is fine, depositContractAddress is the Eth 2.0 staking contract address. As we are only using execution layer we have no use for this. But the updated version of geth is adding this new field, so this is the updated golden file.
e2e/app/geth/config_internal_test.go
Outdated
| @@ -103,7 +103,8 @@ func gethDumpConfigToml(t *testing.T, baseCfg FullConfig) []byte { | |||
| fmt.Sprintf("--volume=%s:/tmp/config.toml", baseFile), | |||
| fmt.Sprintf("ethereum/client-go:%s", Version), | |||
| "dumpconfig", | |||
| "--config=/tmp/config.toml") | |||
| "--config=/tmp/config.toml", | |||
| "--discv5=false") | |||
There was a problem hiding this comment.
the point of this test it to see what geth does with provided config. If it enables discv5 always, no matter what we provide in the config, then it will also do that in prod. So best make it explicit that discv5 is enabled in that case.
So please remove this line, enable discv5 in MakeGethConfig and update golden files to indicate that discv5 is enabled. Since it is very hard to disable it.
kc1116
deleted the
dependabot/go_modules/github.com/ethereum/go-ethereum-1.14.11
branch
Bumps github.com/ethereum/go-ethereum from 1.14.8 to 1.14.11.
Release notes
Sourced from github.com/ethereum/go-ethereum's releases.
... (truncated)
Commits
f3c696fall: release go-ethereum v1.13.8f14f13bparams: go-ethereum v1.14.11 stable40fd887internal/ethapi: remove td field from block (#30386)db6ae7fcmd/geth: remove deprecated lightchaindata db (#30527)e67d5f8eth/catalyst: use setcanonical instead of sethead in simulated fork (#30465)cfe25c7build: use buildx to build multi-platform docker images (#30530)0a21cb4core/txpool/blobpool: use types.Sender instead of signer.Sender (#30473)6b61b54p2p/discover: add config option for disabling FINDNODE liveness check (#30512)283be23params: begin v1.14.11 release cycle1015a42Merge pull request #30522 from ethereum/masterDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)