feat(contracts/core): add fee oracle v2 #1952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinhalliday
force-pushed
the
kh/feeoraclev2
branch
from
2031398
to
ee46861
Compare
ttarsi
approved these changes
Sep 25, 2024
| /** | ||
| * @notice Base gas limit for each xmsg. | ||
| */ | ||
| uint64 public baseGasLimit; |
There was a problem hiding this comment.
maybe a bit more descriptive name - I actually don't know what this is referring to. Is it the minimum gas limit a developer can set?
There was a problem hiding this comment.
No that's xmsgMinGasLimit in the portal .
baseGasLimit is the base gas limit we charge for each xmsg, to account for overhead.
kevinhalliday
force-pushed
the
kh/feeoraclev2
branch
4 times, most recently
from
80c896f
to
3f84a12
Compare
kevinhalliday
force-pushed
the
kh/feeoraclev2
branch
from
3f84a12
to
e471740
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add FeeOracleV2 contract.
issue: #1951