Add tags to metrics #70
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
December 25, 2018 11:02
- Add BaseMetric class with tags that all metric classes inherit from - Enhance registry & InfluxDB to support tags
|
Haven't touched this code for a while, but as far as I remember this branch is valid and works. |
|
Yeah, apologies, I've been swamped and am not an active user of this project anymore (current employer has a different tech stack) |
|
@boarik & @omergertel, thanks for your responses! I guess I'll have to fork and install that branch |
|
I'm using my fork. I'm closing this PR. Thanks all :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Authors: @michalten and @boarik
Hi @michalten and @boarik,
I found this branch and you seem to be the authors of the commits. I hope you don't mind me opening the PR. I just wanted to have a place to discuss the status of tagged metrics
Is there any reason why a PR to the main repo was never opened?
Is the work for having tagged metrics finished? Otherwise, what is missing?
Cheers,
Galbar
PD: It seems that this PR would solve #49