Merge pull request #90 from dominikl/fix_print_pass

Fix print pass
ome · Oct 6, 2020 · b955b27 · b955b27
2 parents 9c11ca7 + 6e0878c
commit b955b27
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,9 @@
+0.4.10 (October 2020)
+---------------------
+
+- fix issue that login password could accidentally be printed
+  in console
+
 0.4.9 (February 2020)
 ---------------------
 

diff --git a/DESCRIPTION b/DESCRIPTION
@@ -1,7 +1,7 @@
 Package: romero.gateway
 Type: Package
-Version: 0.4.9
-Date: 2020-02-26
+Version: 0.4.10
+Date: 2020-10-02
 Title: OMERO R Gateway
 Description: R Wrapper around the OMERO Java Gateway, which
   enables access to an OMERO server within R.

diff --git a/R/OMEROServer.R b/R/OMEROServer.R
@@ -72,6 +72,8 @@ setGeneric(name="connect",
 )
 
 #' Disconnect from an OMERO server
+#' Note: You cannot reconnect using the same OMEROServer instance,
+#' you have to create a new OMEROServer!
 #' 
 #' @param server The server
 #' @return The server in "disconnected" state (if successful)
@@ -417,11 +419,15 @@ setMethod(f="connect",
             if (is.null(server@ctx))
               server@ctx <- new (SecurityContext, .jlong(user$getGroupId()))
 
+            server@password <- "***"
+
             return(server)
           }
 )
 
 #' Disconnect from an OMERO server
+#' Note: You cannot reconnect using the same OMEROServer instance,
+#' you have to create a new OMEROServer!
 #' 
 #' @param server The server
 #' @return The server in "disconnected" state (if successful)