Add LZ4 compression/decompression #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
melissalinkert
previously requested changes
Sep 11, 2024
There was a problem hiding this comment.
Thanks for this, @rharkes.
Before we more carefully consider this for inclusion, could you please submit a contributor license agreement as described in https://ome-contributing.readthedocs.io/en/latest/cla.html?
|
Added |
melissalinkert
approved these changes
Nov 26, 2024
There was a problem hiding this comment.
Thanks again, @rharkes. Merging this in preparation for a release of ome-codecs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've tried to add LZ4 compression in a similar way as was done before for Zstd decompression. However, LZ4 does not tell how large the decompressed data will be. So this is a required parameter in CodecOptions. But I'm not sure how to best enforce it.
The reason I'd like to have LZ4 decompression is that it is used by the imaris fileformat, but it cannot be opened by bioformats at the moment.