Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade cdm-core (netcdf Java) to 5.6.0 #4245

Merged
merged 2 commits into from
Oct 23, 2024

Conversation

melissalinkert
Copy link
Member

See #4217 (comment)

See also netcdf-java release notes: https://github.com/Unidata/netcdf-java/releases.

Copy link
Member

@sbesson sbesson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version bump looks sensible, and from a testing perspective, the nightly repository CI builds are passing with this included. From my side, this is ready for inclusion in Bio-Formats 8.0.0. As noted in #4217 (comment), this might also assist future improvements to the ImarisIMSReader.
The ome-common-java component were also adjusted and released so that the correct versions of the low-level dependencies are resolved independently of the build system. This should allow this to be safely included in the following OMERO release. I'll leave @jburel to review this on his return.

@sbesson sbesson requested a review from jburel October 11, 2024 14:31
Copy link
Member

@jburel jburel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good. Recent failures in the jobs are due the migration and url not available from new VM.

@sbesson sbesson merged commit c401f58 into ome:develop Oct 23, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants