Clean up #55
Merged
Clean up #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbesson
reviewed
Dec 13, 2023
There was a problem hiding this comment.
Looks in agreement with the other OMERO Docker workflows. Comparing to https://github.com/ome/omero-server-docker/blob/master/.github/workflows/main.yml:
jupyterhub/action-major-minor-tag-calculator@v2vsjupyterhub/action-major-minor-tag-calculator@v3- the server Docker image has some extra metadata injected as label
Note that test will currently fail with an updated image see #29 (comment) |
|
Should the metadata computed in 6f65d7b be added as labels in the last upload step?
I saw the updated comment. Re-reading the original issue, it feels like the GNU Octave connector is in a broken state at least partly. Probably worth a discussion to decide how much we want to invest into addressing this. Speaking for myself, I have neither a driver nor the expertise. |
sbesson
approved these changes
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that the docker image has not been updated for the past 2 years