Make service account file & credentials optional arguments, clean up BaseAPI scope #362
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See related issue
Tighten up the interface by accepting
Credentials
directly without the need to pass in falsey values forproject_id
andservice_account_file
.Additionally some minor cleanup to BaseAPI:
self.fcm_end_point
to distinguish instance variable from theFCM_END_POINT_BASE
constant