Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make serv_alu.v synthesizable with Vivado #108

Merged
merged 1 commit into from
Nov 16, 2023
Merged

Conversation

pqcfox
Copy link
Contributor

@pqcfox pqcfox commented Nov 11, 2023

Currently, serv_alu.v uses the one-bit unsized literal '0 which Vivado doesn't support unless a .sv file extension is used.

To recreate the error, run fusesoc run --tool=vivado serv --pnr=none --part=xc7a100tcsg324-1. Synthesis should terminate with an error.

This change resolves the Xilinx synthesis error.

@pqcfox
Copy link
Contributor Author

pqcfox commented Nov 11, 2023

Anything I should do to fix the Read the Docs workflow build failure, or is that expected for now?

@olofk olofk merged commit 7a6d5d3 into olofk:main Nov 16, 2023
2 checks passed
@olofk
Copy link
Owner

olofk commented Nov 16, 2023

Hmm... this is strange. I thought I had fixed the readthedocs failure already. Will need to take another look. Anyway, your patch looks totally fine. Thank you for your contribution. Picked and pushed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants