Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for tree indentation issue #4535

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

krishnasai057
Copy link

Hi Oli,

There is an issue with the indentation of tree when expanded
more details of issue and how to replicate can be found here - #4511.

image

This PR will fix the indentation issue when tree is expanded.

@krishnasai057 krishnasai057 changed the title fix for tree intendation issue fix for tree indentation issue Jul 11, 2024
@olifolkerd
Copy link
Owner

Hey @krishnasai057

Thanks for the PR, and love the idea of the fix, but im afraid the calculation maths does not account for any CSS marging/padding that may be applied to the elements outside of the javascript, which is why those were included in the first place.

Please account for this in your logic and i would be happy to consider this for inclusion.

Cheers

Oli :)

@olifolkerd olifolkerd added the PR Needs Work The PR is a good idea, but needs some updates before it can be merged label Jul 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR Needs Work The PR is a good idea, but needs some updates before it can be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants