Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for null values in D, F and L parsing #35

Merged
merged 1 commit into from
Dec 21, 2020

Conversation

william-andre
Copy link
Contributor

Hello,

I am trying to parse a file with NULL values that are not handled. Here is the fix I propose.

When could I expect the fix to be available through installation on pip?

@william-andre
Copy link
Contributor Author

@olemb Can someone please review this?

@william-andre
Copy link
Contributor Author

@olemb Should I fork the project to have that modification taken into account or is there someone that can merge it? It would be nice to have it by installing with pip...
Otherwise I would have to have the fork as a submodule or as a git+ dependency in the requirements.txt file , which I would like to avoid.

@olemb olemb merged commit 9617844 into olemb:master Dec 21, 2020
@olemb
Copy link
Owner

olemb commented Dec 21, 2020

I've merged your change and will include it in the next update. Until then it's available in the master branch. Can you pip install from there?

Hopefully this also solves #42.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants