Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send 'set gal type' before reading PES info bytes. Fixes issue 16 #17

Closed
wants to merge 2 commits into from
Closed

Conversation

rreilink
Copy link
Contributor

Fixes issue #16 .

Send 'set gal type' before reading info bytes in operationReadInfo of PC application
Add 'g' command to help text of Arduino code

@ole00
Copy link
Owner

ole00 commented Mar 28, 2022

It seems to me your new command 'g' is already implemented by passing the '-t' parameter. Am I correct? There is a function call operationSetGalType() in main() that sets the gal type if it was passed as a parameter on the command line. See here:

Screenshot_2022-03-28_19-02-09

Also the README.md mentions the gal type should be passed along with the 'i' command:

./afterburner i -t [GAL_type]

@rreilink
Copy link
Contributor Author

I did try this I think, and it did not seem to work. I'll investigate, since your highlighted code does indeed make me think it should already be correct. I'll keep you posted.

@rreilink
Copy link
Contributor Author

This is not the right way to fix it, I'll make another PR

@rreilink rreilink closed this Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants