Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to fix upload feature on empty content screen centering #646

Merged
merged 2 commits into from
Nov 21, 2024

Conversation

guergana
Copy link
Collaborator

Copy link

cloudflare-workers-and-pages bot commented Nov 16, 2024

Deploying opendataeditor with  Cloudflare Pages  Cloudflare Pages

Latest commit: a0ef717
Status: ✅  Deploy successful!
Preview URL: https://d5b5a431.opendataeditor.pages.dev
Branch Preview URL: https://642-upload-centered.opendataeditor.pages.dev

View logs

@guergana
Copy link
Collaborator Author

guergana commented Nov 16, 2024

@romicolman is there a way you can test this again on a Windows 10 OS? I tried a fix that possibly fixes the issue. But I can't reproduce the issue exactly in my virtual machine. The issue I was seeing is that the element was first at the top of the screen as illustrated here, but then it jumped to the center. With my current fix it's showing at the center since the start, but we need to test it on the machines having the original issue. 🙏

@romicolman
Copy link
Collaborator

Hi @guergana! I can't test it because of my OS and the person who can test it would need to download a new pre-release version of the app. @pdelboca is there a way you can check the change We need to make a new release today or tomorrow so that OKFN Brazil has the latest version of the app for the videos, so we can also merge it and I'll ask the user to check it.

@pdelboca pdelboca self-requested a review November 21, 2024 12:24
@guergana guergana merged commit 191d862 into main Nov 21, 2024
9 checks passed
@guergana guergana deleted the 642-upload-centered branch November 21, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Windows 10 Pro - Upload feature is not centered on the screen
3 participants