-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make panels full screen #636
Conversation
guergana
commented
Nov 8, 2024
- fixes Metadata panel in full screen #619
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
It addresses #619 but, of course, it's not a proper solution technically as it needs to be done in #494.
Also, not releated to this PR, but previously Metadata/Source/etc controls had an active state indicating what is enabled. And now it you click on "Metadata" you basically have no idea what is the state and how to get back to the table
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @guergana! I checked it on Mac. When you click on a specific category (Schema), for example, and you later click on a subcategory (such as Field), the datagrid pops-up:
Here is a video showing the problem:
Grabacion.de.pantalla.2024-11-11.a.la.s.9.49.05.a.m.mov
Deploying opendataeditor with Cloudflare Pages
|
@romicolman i have pushed some changes. Can you please test again? 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works on Mac :)