Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make panels full screen #636

Merged
merged 3 commits into from
Nov 13, 2024
Merged

Make panels full screen #636

merged 3 commits into from
Nov 13, 2024

Conversation

guergana
Copy link
Collaborator

@guergana guergana commented Nov 8, 2024

Copy link
Collaborator

@roll roll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

It addresses #619 but, of course, it's not a proper solution technically as it needs to be done in #494.

Also, not releated to this PR, but previously Metadata/Source/etc controls had an active state indicating what is enabled. And now it you click on "Metadata" you basically have no idea what is the state and how to get back to the table

Copy link
Collaborator

@romicolman romicolman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @guergana! I checked it on Mac. When you click on a specific category (Schema), for example, and you later click on a subcategory (such as Field), the datagrid pops-up:

Here is a video showing the problem:

Grabacion.de.pantalla.2024-11-11.a.la.s.9.49.05.a.m.mov

Copy link

cloudflare-workers-and-pages bot commented Nov 12, 2024

Deploying opendataeditor with  Cloudflare Pages  Cloudflare Pages

Latest commit: 5d1a917
Status: ✅  Deploy successful!
Preview URL: https://c40b04da.opendataeditor.pages.dev
Branch Preview URL: https://619-panels-full-screen.opendataeditor.pages.dev

View logs

@guergana
Copy link
Collaborator Author

Hi @guergana! I checked it on Mac. When you click on a specific category (Schema), for example, and you later click on a subcategory (such as Field), the datagrid pops-up:

Here is a video showing the problem:
Grabacion.de.pantalla.2024-11-11.a.la.s.9.49.05.a.m.mov

@romicolman i have pushed some changes. Can you please test again? 🙏

Copy link
Collaborator

@romicolman romicolman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works on Mac :)

@guergana guergana merged commit eb73cdf into main Nov 13, 2024
9 checks passed
@guergana guergana deleted the 619-panels-full-screen branch November 13, 2024 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Metadata panel in full screen
3 participants