Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable preview for text files #632

Merged
merged 1 commit into from
Nov 6, 2024
Merged

Disable preview for text files #632

merged 1 commit into from
Nov 6, 2024

Conversation

guergana
Copy link
Collaborator

@guergana guergana commented Nov 6, 2024

@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

Deploying opendataeditor with  Cloudflare Pages  Cloudflare Pages

Latest commit: ef19eda
Status: ✅  Deploy successful!
Preview URL: https://84f89df6.opendataeditor.pages.dev
Branch Preview URL: https://623-disable-text-files.opendataeditor.pages.dev

View logs

@roll
Copy link
Collaborator

roll commented Nov 6, 2024

@guergana
If user can't open anything except for table then it will be easier just to remove File and Text controllers completely

romicolman
romicolman approved these changes Nov 6, 2024
View reviewed changes
Copy link
Collaborator

@romicolman romicolman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works OK :) Thanks

@guergana guergana merged commit a27b1fa into main Nov 6, 2024
9 checks passed
@guergana guergana deleted the 623-disable-text-files branch November 6, 2024 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romicolman romicolman romicolman approved these changes

@roll roll Awaiting requested review from roll

@pdelboca pdelboca Awaiting requested review from pdelboca

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Disable preview for .txt files
3 participants
@guergana @roll @romicolman