Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

278 - MacOS Notarize #621

Merged
merged 7 commits into from
Nov 1, 2024
Merged

278 - MacOS Notarize #621

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
b154d34
278 - Add MacOS notarize files and secrets
pdelboca Oct 31, 2024
e3a1e12
Fix typo
pdelboca Oct 31, 2024
b3f36b6
Allow notarize in PRs
pdelboca Oct 31, 2024
1aaf2b8
Add notarize secrets to the action
pdelboca Oct 31, 2024
e5da122
Upgrade electron-builder
pdelboca Oct 31, 2024
eecebb1
Add some extra resources to the file
pdelboca Oct 31, 2024
2ab184b
Clean debugging option
pdelboca Oct 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .github/workflows/general.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,11 @@ jobs:
run: make dist
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
CSC_LINK: ${{ secrets.CSC_LINK }}
CSC_KEY_PASSWORD: ${{ secrets.CSC_KEY_PASSWORD }}
APPLE_ID: ${{ secrets.APPLE_ID }}
APPLE_APP_SPECIFIC_PASSWORD: ${{ secrets.APPLE_APP_SPECIFIC_PASSWORD }}
APPLE_TEAM_ID: ${{ secrets.APPLE_TEAM_ID }}
- name: Archive build artifacts
uses: actions/upload-artifact@v4
with:
Expand Down
10 changes: 8 additions & 2 deletions electron-builder.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,15 @@ linux:
- deb

# Macos

# Some resources to understand values and github secrets
# https://kilianvalkhof.com/2019/electron/notarizing-your-electron-application/
# https://www.electron.build/code-signing
# https://www.electron.build/app-builder-lib.interface.macconfiguration#notarize
# https://github.com/electron/notarize
mac:
notarize: false
hardenedRuntime: true
entitlements: 'entitlements.mac.plist'
entitlementsInherit: 'entitlements.mac.plist'

# Windows
# Variable ${name} doesn't work on windows
Expand Down
10 changes: 10 additions & 0 deletions entitlements.mac.plist
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
<plist version="1.0">
<dict>
<key>com.apple.security.cs.allow-unsigned-executable-memory</key>
<true/>
<key>com.apple.security.cs.allow-jit</key>
<true/>
</dict>
</plist>
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@
"delay": "6.0.0",
"dirty-json": "0.9.2",
"electron": "31.3.0",
"electron-builder": "^24.13.3",
"electron-builder": "^25.0.5",
"electron-updater": "6.2.1",
"electron-vite": "2.1.0",
"eslint": "8.45.0",
Expand Down
Loading