-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Publish dialog #602
Publish dialog #602
Conversation
Deploying opendataeditor with Cloudflare Pages
|
@guergana But what is this? =) It might be help messages that needs to be written for publish editors |
I mean the message itself is random not related to publishing. I guess it's because it was just bootstrapped but never written as it wasn't visible previously. It might need a follow-up issue to fix it |
@roll I don't understand what is there to fix. This message is part of this ticket. Do you mean the text doesn't make any sense? Yeah, we probably need to ask @Faithkenny or @romicolman about the text, if this is what you mean. |
@guergana What I'm saying is that this file needs to be filled with correct help messages - https://github.com/okfn/opendataeditor/blob/main/client/components/Editors/Portal/help.yaml - e.g. "User -- a github username you can find in your Github account", "Repo - ..." etc. @romicolman something not to forget as a follow-up |
5fa8272
to
723cc4b
Compare
I can include them here also once I have text of the messages. @romicolman @roll or follow up PR is also fine. |
80d5908
to
b1b6cb6
Compare
This PR implements exclusively the 'Publish' dialog