fix: Three Sigma audit fixes (#2)

ojo-network · Dec 6, 2024 · 00b1548 · 00b1548
1 parent af79d0b
commit 00b1548
Show file tree

Hide file tree

Showing 2 changed files with 33 additions and 0 deletions.
diff --git a/src/OjoPTOraclePriceAdapter.sol b/src/OjoPTOraclePriceAdapter.sol
@@ -13,13 +13,38 @@ contract OjoPTOraclePriceAdapter is MinimalAggregatorV3Interface {
 
     string public description;
 
+    /// @notice thrown when the Pendle market decimals are not 18
+    uint256 internal constant OjoPTOraclePriceAdapter__MarketDecimalsNotSupported = 10_000;
+
+    /// @notice thrown when the Pendle market Oracle has not been initialized yet
+    uint256 internal constant OjoPTOraclePriceAdapter__MarketNotInitialized = 10_001;
+
+    error OjoPTOraclePriceAdapterError(uint256 errorId_);
+
     constructor(address _ptoracle, address _market, string memory _description) {
         require(_ptoracle != address(0), "_ptoracle zero address");
         require(_market != address(0), "_market zero address");
 
         PTOracle = _ptoracle;
         market = _market;
         description = _description;
+        if (MinimalAggregatorV3Interface(_market).decimals() != decimals) {
+            revert OjoPTOraclePriceAdapterError(OjoPTOraclePriceAdapter__MarketDecimalsNotSupported);
+        }
+
+        IPTOracle oracle = IPTOracle(PTOracle);
+
+        {
+            (bool increaseCardinalityRequired_,, bool oldestObservationSatisfied_) = oracle.getOracleState(
+                market,
+                900 // 15 mins twap duration
+            );
+            if (increaseCardinalityRequired_ || !oldestObservationSatisfied_) {
+                // ensure pendle market Oracle is ready and initialized see
+                // https://docs.pendle.finance/Developers/Oracles/HowToIntegratePtAndLpOracle
+                revert OjoPTOraclePriceAdapterError(OjoPTOraclePriceAdapter__MarketNotInitialized);
+            }
+        }
     }
 
     /// @inheritdoc MinimalAggregatorV3Interface

diff --git a/src/interfaces/IPTOracle.sol b/src/interfaces/IPTOracle.sol
@@ -3,4 +3,12 @@ pragma solidity >=0.5.0;
 
 interface IPTOracle {
     function getPtToAssetRate(address market, uint32 duration) external view returns (uint256);
+
+    function getOracleState(
+        address market,
+        uint32 duration
+    )
+        external
+        view
+        returns (bool increaseCardinalityRequired, uint16 cardinalityRequired, bool oldestObservationSatisfied);
 }