Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

themes: Add a new theme developer focusing on devs #526

Merged
merged 22 commits into from
Sep 11, 2024

Conversation

marco-gallegos
Copy link
Contributor

what's new?

this PR includes a new theme, I have used it around a year, im a developer and is very helpful even better than any other complex configuration in oh_my_zsh not fully finished but is good enough.

I think is a good idea share this with more people.

@akinomyoga
Copy link
Contributor

akinomyoga commented Feb 11, 2024

Can you check the last paragraph of § You have an addition - CONTRIBUTING.md?

@akinomyoga
Copy link
Contributor

please also update themes/THEMES.md.

@marco-gallegos
Copy link
Contributor Author

sorry I was working on it :D @akinomyoga

Copy link
Contributor

@akinomyoga akinomyoga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for updating the necessary parts for the new theme. Then, let's move on to the actual codes. I left comments. Could you update them?

themes/developer/developer.theme.sh Outdated Show resolved Hide resolved
themes/developer/developer.theme.sh Outdated Show resolved Hide resolved
themes/developer/developer.theme.sh Outdated Show resolved Hide resolved
themes/developer/developer.theme.sh Outdated Show resolved Hide resolved
themes/developer/developer.theme.sh Outdated Show resolved Hide resolved
themes/developer/developer.theme.sh Outdated Show resolved Hide resolved
themes/developer/developer.theme.sh Outdated Show resolved Hide resolved
themes/developer/developer.theme.sh Outdated Show resolved Hide resolved
@marco-gallegos
Copy link
Contributor Author

awesome, I can update this but not today, let me work on it :D

@akinomyoga
Copy link
Contributor

Thanks.

@akinomyoga akinomyoga force-pushed the theme/developer_new_theme branch from 0c6b6ea to 6f8aadf Compare September 10, 2024 03:17
themes/developer/developer.theme.sh Outdated Show resolved Hide resolved
themes/developer/developer.theme.sh Outdated Show resolved Hide resolved
@akinomyoga akinomyoga force-pushed the theme/developer_new_theme branch from b012517 to cdc17ef Compare September 11, 2024 06:55
This attempted to run the commands to extract information in parallel,
but this may result in interleaved information in some operating
system (depending on the way how the C library performs buffering and
how the syscall write(2) issued by multiple processes would interfere
with one another).

There are other parts we can optimize, so we would compensate the
overhead with the optimization of other parts.
@akinomyoga akinomyoga force-pushed the theme/developer_new_theme branch from cdc17ef to 7367379 Compare September 11, 2024 08:10
@akinomyoga akinomyoga changed the title theme/developer added a new theme focused on devs themes: Add a new theme developer focusing on devs Sep 11, 2024
@akinomyoga akinomyoga merged commit f53beb6 into ohmybash:master Sep 11, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants