-
-
Notifications
You must be signed in to change notification settings - Fork 672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
themes: Add a new theme developer
focusing on devs
#526
themes: Add a new theme developer
focusing on devs
#526
Conversation
Can you check the last paragraph of § You have an addition - |
|
sorry I was working on it :D @akinomyoga |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for updating the necessary parts for the new theme. Then, let's move on to the actual codes. I left comments. Could you update them?
awesome, I can update this but not today, let me work on it :D |
Thanks. |
0c6b6ea
to
6f8aadf
Compare
"grep -P" is not POSIX. Instead of using PCRE to extract the results separated by "---", we can simply separate the results with newlines and use standard utilities (which assumes line-oriented data) to manipulate the data.
b012517
to
cdc17ef
Compare
This attempted to run the commands to extract information in parallel, but this may result in interleaved information in some operating system (depending on the way how the C library performs buffering and how the syscall write(2) issued by multiple processes would interfere with one another). There are other parts we can optimize, so we would compensate the overhead with the optimization of other parts.
cdc17ef
to
7367379
Compare
developer
focusing on devs
what's new?
this PR includes a new theme, I have used it around a year, im a developer and is very helpful even better than any other complex configuration in oh_my_zsh not fully finished but is good enough.
I think is a good idea share this with more people.