Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib/git: Fix problems caused by uses of Zsh features #484

Merged
merged 9 commits into from
Oct 14, 2023

Conversation

akinomyoga
Copy link
Contributor

@akinomyoga akinomyoga commented Oct 12, 2023

This also includes refactoring.

@akinomyoga
Copy link
Contributor Author

@hyperupcall Hi, how are you doing? The GitHub Action lint (Check EditorConfig Format), which you introduced in #433, has been very helpful so far. Thank you! I'm reaching out to you because a few days ago, the action seems to have started to always produce an error. Could you take the time to look at it when you have time? It seems to be related to the Go version of the environment, but I haven't carefully examined it.

@hyperupcall
Copy link
Contributor

hyperupcall commented Oct 13, 2023

Hey! I'll take a look at it tomorrow. My best guess right now is that an invalid assumption about modules was made, like in relation to GO111MODULEs.

Edit: Here is the root cause: editorconfig/editorconfig-core-go@73c37c4

@akinomyoga
Copy link
Contributor Author

Thank you!

@akinomyoga akinomyoga merged commit 07d9382 into ohmybash:master Oct 14, 2023
4 checks passed
@akinomyoga akinomyoga deleted the prompt-git branch October 14, 2023 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants