-
-
Notifications
You must be signed in to change notification settings - Fork 672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lib/git: Fix problems caused by uses of Zsh features #484
Conversation
@hyperupcall Hi, how are you doing? The GitHub Action |
Hey! I'll take a look at it tomorrow. My best guess right now is that an invalid assumption about modules was made, like in relation to Edit: Here is the root cause: editorconfig/editorconfig-core-go@73c37c4 |
Thank you! |
4d541cf
to
f089d15
Compare
8fd3e80
to
1dfbd39
Compare
This also includes refactoring.
command git
for prompts and completions indirect through the function_omb_prompt_git
. This will be a base for global: Specify-c core.fsmonitor=
to git commands #428 and lib/omb-prompt-base: Set a timeout on git commands #173. As far as we directly callcommand git
, we need to specify the command modifications for timeouts and git settings for every invocation ofcommand git
, which is not useful.