Erbb vcvrack 2.5 support #680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
macOS 11 image happens to be unavailable on the same day, so upgrade to macOS 12.
ohmtech-rdi
force-pushed
the
erbb-vcvrack-2.5-support
branch
from
e064669
to
3dc36ef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for VCV Rack 2.5. In particular the path to the plug-in modules changed again.
macOS
In the code it is the first path returned by
It happens that in core python, there is no way to get this path cleanly. So for now we are hardcoding the path, which might breaks on some macOS installations. Anyway this is also what the makefile does.
The GitHub workflow was updated to macOS 12, as it just so happens that macOS 11 runner image is unavailable on the same day.
Linux
The path was also changed on Linux. We also support
XDG_DATA_HOME.Windows
The path was also changed on Windows.