Fixed the bugs in displaying the grid with fit_into_width
#14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 9, 2021 19:03
|
@ogham is it possible for those changes to be merged? 0.2.0 feels fundamentally broken because of the presence of those bugs. In fact it seems like term-grid gives up on producing a grid if the content has to produce more than one row in any way. I can confirm that 0.1.7 works fine for me, and so does 0.2.0 after applying this patch. |
|
@mtsoltan We've finally decided to make a fork of this library for uutils: https://github.com/uutils/uutils-term-grid. Feel free to reopen this PR there! |
|
@tertsdiepraam |
|
Forgot about this, just did it now! Sorry~ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes were initiated to fix the behavior of term-grid in uutils's
ls, which uses term-grid 0.1.7 but can't upgrade to 0.2.0 due to the existence of these bugs.Ideally, I'd like to upgrade to 0.2.0, offloading a lot of padding/alignment code to term-grid instead.
Things I've taken care of:
Things I've not taken care of, yet: