Fix menu buttons (#236)

* Make foreach function calls consistent * Filter menu button properties for Card forms
oetiker · Sep 19, 2024 · 7ff0263 · 7ff0263
1 parent c434c8a
commit 7ff0263
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/CHANGES b/CHANGES
@@ -1,3 +1,5 @@
+  - filter menuButtonProperties
+
 0.50.2 2024-09-18 16:42:18 +0200 Tobias Oetiker <[email protected]>
 
  - fix regression with missing defaults for app and log in user object

diff --git a/lib/CallBackery/qooxdoo/callbackery/source/class/callbackery/ui/plugin/Action.js b/lib/CallBackery/qooxdoo/callbackery/source/class/callbackery/ui/plugin/Action.js
@@ -245,9 +245,12 @@ qx.Class.define("callbackery.ui.plugin.Action", {
                             }
                         }
                         if (mbs) {
-                            mmButton.set(mbs);
+                            let mbsFiltered = Object.fromEntries(
+                                ['visibility', 'enabled', 'label', 'icon'].filter(key => key in mbs).map(key => [key, mbs[key]])
+                            );
+                            mmButton.set(mbsFiltered);
                             if (btCfg.key) {
-                                this._menuButtonSetMap[btCfg.key] = mbs;
+                                this._menuButtonSetMap[btCfg.key] = mbsFiltered;
                             }
                         }