-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/add thermal building model #985
base: dev
Are you sure you want to change the base?
Conversation
Hello @Maxhi77! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2023-10-12 09:52:01 UTC |
import pytest | ||
from types import SimpleNamespace | ||
|
||
from oemof.tools import economics |
Check notice
Code scanning / CodeQL
Unused import Note test
########################################################################## | ||
|
||
# check if the new result object is working for custom components | ||
results = solph.processing.results(om) |
Check warning
Code scanning / CodeQL
Variable defined multiple times Warning test
redefined
building_status = "no_refurbishment" | ||
expert_mode = None | ||
if expert_mode: | ||
if building_status == "no_refurbishment": |
Check warning
Code scanning / CodeQL
Unreachable code Warning
building_example = None | ||
|
||
# Generates 5RC Building-Model | ||
building_status = "no_refurbishment" |
Check notice
Code scanning / CodeQL
Unused local variable Note
building_status = "no_refurbishment" | ||
expert_mode = None | ||
if expert_mode: | ||
if building_status == "no_refurbishment": |
Check warning
Code scanning / CodeQL
Unreachable code Warning
import pprint as pp | ||
import logging | ||
|
||
import pandas as pd |
Check notice
Code scanning / CodeQL
Unused import Note
raise ValueError(f"All keys in {field_name} must start with {required_prefix}") | ||
|
||
try: | ||
int_part = int(key[len(required_prefix):]) |
Check notice
Code scanning / CodeQL
Unused local variable Note
building_example = None | ||
|
||
# Generates 5RC Building-Model | ||
building_status = "no_refurbishment" |
Check notice
Code scanning / CodeQL
Unused local variable Note
timeindex=date_time_index, infer_last_interval=False | ||
) | ||
|
||
epc_heat_pump = economics.annuity(capex=1000, n=20, wacc=0.05) |
Check notice
Code scanning / CodeQL
Unused local variable Note
es.results["meta"] = solph.processing.meta_results(model) | ||
results = es.results["main"] | ||
custom_building = views.node(results, "GenericBuilding") | ||
electricity_bus = solph.views.node(results, "electricity") |
Check notice
Code scanning / CodeQL
Unused local variable Note
This pull request aims to add a 5RC thermal building model to oemof. The building model is based on capacitors and resistances and is explained in detail in ISO 13790:2008. Building configurations for the 5RC model can be calculated based on the tabula database.
The idea is to extract all information from a tabula database CSV file and calculate a 5RC building configuration based on this information. For this purpose, functions to calculate solar gains through windows were added as well. Solar gains through windows are connected to window-specific values, which are extracted from the CSV file. For the calculation of this solar gains, a weather file was added. With the building configuration, a building model can be generated. The user has to set temperatures for heating and cooling in the building model.
Right now, the heat_flows goes into the model as input and cooling_flows as output. All in all the idea is to optimize the internal temperature of the building, called t_air, to use the building as thermal storage and save energy and cost.
In this bullet points I want to summarize open questions / todos
ISO 13790:2008 “Energy performance of buildings –Calculation of energy use for space heating and cooling“.
Tabula - https://webtool.building-typology.eu/#bm , https://episcope.eu/building-typology/tabula-webtool/