-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/objective function weighted sum #840
base: dev
Are you sure you want to change the base?
Feature/objective function weighted sum #840
Conversation
Hello @minhki95! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2022-05-02 11:17:53 UTC |
Thanks for the approach, looks interesting to me! Conceptually I would start on the energy system class level before building the model, i.e.:
We should discuss this at the meeting with @gnn and @p-snft :)...maybe we can take a session on Thursday or on Friday |
Thank you for your first remarks. |
Hey @minhki95 Concerning the weighted sum method: We (my colleagues with whom I've created the code and me) haven't been working on that feature for some time now. Primarily, because we weren't shure if the benefits pay off for all the changes we made. They were a bit more extensive, as we tried to implement more of a framework for multi-objective optimization techniques, rather than a single feature. As @p-snft pointed out in the PR-thread: in many cases you can simply sum the variable cost terms with the appropriate weights before solving. Is that maybe an option for you as well? Based on the "framework" we've implemented I've also added a lexicographic approach in my private repo-clone but have not yet had the time to pick up where we left with the PR and transfer the changes to it. If there is interest, I would give it a higher priority. In case you want to get in touch: Is there some way I can send you my contact details privately? I wouldn't want them to be publicly readable here. Unfortunately, I cannot participate in the oemof-meeting in two weeks. |
Please do so using this address: [email protected]. |
Hey @minhki95, |
Hi @lensum, thank you for reaching out. Yes, I am still working with it. But mainly I use the grouping for postprocessing. My focus has shifted to an analysis of the market interactions between the different cells under global optimization. But I would still be interested what functionalities you and @p-snft have intended and if this has any implications for the optimization. Therefore I have dismissed the idea of the weighted sum as the choice of the weightings was too arbitrary and based on empiricism. You can reach out to me on my personal mail adress as I have no direct affilition with RLI anymore. |
What functionality does it implement?
Where is it located?
Modifications have been made in the oemof-solph repository but also in the oemof-network repository see the PR below:
Add cell_list attribute to Node class oemof-network#18
In oemof-solph several components which are linked to the objective function have to be modified. So far the following components have been edited for this: